Harden sd-viewer configuration and provision mailcap default rules; bump version #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures no default disposable VM is configured - Prevents qubes.GetImageRGBA calls, which could be used to open disposable VMs. This policy is applied to all SecureDrop Workstation VMs, as this RPC call is not required by any current VMs.
The updater must perform a full state run in order to apply the mailcap hardening inside AppVM private volumes. Create the necessary run-everything flag via RPM postinst. The updater logic will automatically clean up the flags are it runs. We'll need to remove this logic from postinst in the subsequent release of 'securedrop-workstation-dom0-config', so it doesn't recreate the flag.
conorsch
approved these changes
Mar 10, 2021
This was referenced Mar 23, 2021
cfm
pushed a commit
that referenced
this pull request
Apr 1, 2024
Harden sd-viewer configuration and provision mailcap default rules; bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
default_dispvmsetting)qubes.GetImageRGBApolicy for all workstation VMs (it otherwise can be used to launch disposable VMs)sdw-admin --applyrun, which is enforced in postinst by dropping a migration flag (interpreted via https://github.com/freedomofpress/securedrop-workstation/blob/main/dom0/securedrop-check-migration). This assumes the package is updated via the graphical updater. (Commit by @conorsch.)Side effects of RPC policy change
There should not be any negative impact from restricting the
GetImageRGBApolicy across SecureDrop Workstation VMs.qvm-convert-imgwill no longer work in, e.g.,sd-devices, butqvm-convert-pdfalready does not work due to our existingqubes.PdfConvertpolicy. If we want to support PDF/image conversion in disposable VMs in future, that will require its own configuration.Test plan
Note: Mailcap configuration testing is handled in freedomofpress/securedrop-builder#221, which is dependent on this PR, and therefore not covered below.
securedrop-workstationcheckout indom0, runmake cloneto build and fetch a fresh RPM.dom0checkout, enter the directoryrpm-build/RPMS/noarch. There should be a 0.5.3 RPM. Install it viasudo dnf install securedrop-workstation-dom0-config-0.5.3-1.fc25.noarch.rpm./opt/securedrop/launcher/sdw-launcher.py --skip-delta 0indom0.qrexec-client-vm ‘@dispvm’ qubes.GetImageRGBA < /dev/urandomRequest refusedand that no disposable VM is opened.dom0, runqvm-prefs sd-viewer default_dispvm.sd-viewer)securedrop-workstationdirectory, ensure thatconfig.jsonis present, then runmake testtest_sd_viewer_configare passing.sd-logqrexec-client-vm ‘@dispvm’ qubes.GetImageRGBA < /dev/urandomdoes not open a disposable VM.