Skip to content

Commit

Permalink
Disables strict xfail on PaX flag config tests
Browse files Browse the repository at this point in the history
The "strict=true" pragma on pytest xfail means that the config test
suite will exit non-zero if the tests pass. We added strict=True in order
to understand better the problem of PaX flags not matching, and it
appears we've confirmed that the age of installed packages is sufficient
determinant. That is, if apt such as grub are upgraded as part of the
install, then PaX flags set by the grsecurity role will be clobbered
very quickly.
  • Loading branch information
Conor Schaefer committed Feb 8, 2019
1 parent 66ac605 commit cbd810d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions molecule/testinfra/staging/common/test_grsecurity.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ def test_apt_autoremove(host):
assert "The following packages will be REMOVED" not in c.stdout


@pytest.mark.xfail(strict=True,
reason="PaX flags unset at install time, see issue #3916")
@pytest.mark.xfail(reason="PaX flags unset at install time, see issue #3916")
@pytest.mark.parametrize("binary", [
"/usr/sbin/grub-probe",
"/usr/sbin/grub-mkdevicemap",
Expand Down

0 comments on commit cbd810d

Please sign in to comment.