Image on /lookup does not take you back to the homepage

[runasand]

Say the source is on /lookup and has just submitted something and wishes to go back to the homepage. The logical step would be to click on the SecureDrop logo on the left, but doing so seems to just refresh the page the source is currently on. Is this the expected behavior? If so, do we want to require users to edit the URL to go back to the homepage?

[garrettr]

@runasand That's intentional, you can look up at the issue/PR where it was implemented. Otherwise it is easy for sources to accidentally go back to the home page and click "Submit documents" again, which will clear their cookies (logging them out). Currently the "check for replies" page does not check if the user is already logged in, so they will be locked out of the account they just created if they didn't memorize/record their code name.

Proposals for an alternative flow welcome.

[runasand]

Hah, I actually hit that issue a few minutes after opening this. I agree it makes sense to not have the image point to the homepage on /lookup, and I will think about alternative flows we can consider.

[ikehz]

How about we just create a "Logout" link, so that it's clear that, if they click it, they'll have to use their code name to get back in?

[diracdeltas]

++ to explicit logout link. @ihmccreery is working on this at the hackathon.

[ikehz]

@garrettr said of my patch:

Does not close #682, you did not change the link for the image on /lookup.

Further, I'm not sure I think sources should have a logout flow. Their cookies are session cookies, which automatically expire when the browser is closed. Logout flows seems to make more sense if cookies are persistent, or if multiple people want to access their individual accounts on the same website on the same computer (unlikely for SecureDrop).

[ikehz]

When I was playing around with SecureDrop, as a brand new user, my first instinct for workflow were as follows:

1. Open up the source index
2. "Submit documents for the first time"
3. Submit a document
4. Logout

When I tried to logout, I couldn't figure out how.

As a (perhaps paranoid) user, it makes me feel weird to not have ability to logout explicitly. Perhaps there's more to be done than returning to the index, but I think it's confusing and weird-feeling to not allow a source to do an action that makes them sure that they've logged out.

[garrettr]

This is straightforward to fix, but a little tricky because you need to handle what happens if the source reloads the /generate page after having already created a codename (since this is easy to do by hitting the "Back" button). Since we re-use the same key in the session on both /generate and /lookup, re-visiting /generate would pop the original codename, effectively locking you out if you had failed to memorize or write down the first codename.

The current behavior is intentional, and is designed to prevent this outcome (since it is potentially disastrous, definitely confusing, and very easy to do by accident). We can improve this (and restore the intuitive behavior of clicking on the logo on /lookup), but will need to add supporting UX changes as well.

[redshiftzero]

Looks like this was implemented in PR #1165. Closing...