-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added functionality to load test data during staging provisioning #5143
added functionality to load test data during staging provisioning #5143
Conversation
c663ec9
to
0c09f85
Compare
0c09f85
to
bb97849
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zenmonkeykstop tested as follows using your test plan:
- checkout this branch
- create a directory
install_files/ansible-base/test-data
and copy the backup file there. - run
make build-debs && make staging
, verify that it completes successfully - create an admin account, log into the JI, and verify that there are no sources or other journalist accounts on the instance
- run
TEST_DATA_FILE="sd-backup.tar.gz" make staging
and verify that it completes successfully - verify that the SI and JI addresses remain unchanged from the initial run, and have not been set to those in the backup tarball
- create an admin account, log into the JI, and verify that the sources and journalist accounts on the instance match those from the backup tarball
- verify that source login and submission, and journalist reply processes work correctly.
Additional tests - backup is properly gitignored
I ran into #4364 but it seems unrelated these changes.
I think prior to merge, it might be worth capturing the instructions from the test plan into some developer-facing docs? What do you think?
No problem! added in a description (and admonishment not to use data from a live instance for testing) in the development docs. |
2f2bda0
to
41e03e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Full test plan passes locally. @emkll already asked for, and received, docs, so adding a +1 for merge.
CI failed on the updater gui tests, which is unrelated, so restarted the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is now passing, merging!
Status
Ready for review
Description of Changes
Fixes #5140 .
Adds option to provision a staging environment using instance data from a backup file.
Testing
Using an existing SecureDrop backup tarball (say,
sd-backup.tar.gz
):install_files/ansible-base/test-data
and copy the backup file there.make build-debs && make staging
, verify that it completes successfullyTEST_DATA_FILE="sd-backup.tar.gz" make staging
and verify that it completes successfullyDeployment
Development/QA-only change
Checklist
If you made non-trivial code changes: