Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate app-tests and app-page-layout-tests jobs to GitHub Actions #7220

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Aug 14, 2024

Status

Ready for review

Description of Changes

Split the non-pageslayout functional tests to their own job for a bit of extra parallelism.

Image pre-building/caching doesn't seem to be working the same way in GitHub Actions, so I've dropped it for now and we can add it back in later on.

Testing

How should the reviewer test this PR?

  • CI passes
  • visual review

Deployment

Any special considerations for deployment? n/a

Checklist

  • Linting (make lint) and tests (make test) pass in the development container

Split the non-pageslayout functional tests to their own job for a bit of
extra parallelism.

Image pre-building/caching doesn't seem to be working the same way in
GitHub Actions, so I've dropped it for now and we can add it back in
later on.
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. As discussed just now, with this change we won't retain CircleCI's gating on lint: we'll just let it rip.

@cfm cfm merged commit 42c3a99 into develop Aug 15, 2024
30 checks passed
@legoktm legoktm deleted the gha-tests branch August 15, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants