Remove tests checking that no apparmor profiles are complaining #7308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu noble now has some transmission-related profiles in complain mode. We don't really care about this, so just remove the test. Ideally distros will continue to add more apparmor profiles, even if they're complain-only to start.
|
Is transmission actually being installed tho? In that case we should be removing said package, not disabling tests that get caught up on it. |
|
No, it isn't. But Ubuntu is installing a bunch of profiles like transmission, discord, steam, etc. I didn't check which package though (can do tomorrow).
…On November 4, 2024 11:18:05 PM UTC, zenmonkeykstop ***@***.***> wrote:
Is transmission actually being installed tho? In that case we should be removing said package, not disabling tests that get caught up on it.
--
Reply to this email directly or view it on GitHub:
#7308 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
|
Here's all the profiles the base |
zenmonkeykstop
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Ubuntu noble now has some transmission-related profiles in complain mode. We don't really care about this, so just remove the test. Ideally distros will continue to add more apparmor profiles, even if they're complain-only to start.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a