Have app-code depend on apparmor in noble #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a system upgrade, the securedrop-app-code postinst tries to enable the apparmor profiles for apache2 and tor, except it uses newer apparmor syntax, which can fail if apparmor hasn't already been upgraded. The easiest and correct way to ensure that securedrop-app-code is upgraded after apparmor is by setting a versioned dependency. We need to do a bit of makefile magic so it only applies to noble builds though, and a test verifies that.
zenmonkeykstop
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
During a system upgrade, the securedrop-app-code postinst tries to enable the apparmor profiles for apache2 and tor, except it uses newer apparmor syntax, which can fail if apparmor hasn't already been upgraded.
The easiest and correct way to ensure that securedrop-app-code is upgraded after apparmor is by setting a versioned dependency. We need to do a bit of makefile magic so it only applies to noble builds though, and a test verifies that.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist