v1: Set RAFT_UPDATE_STATE flag when the state changes

Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
freeekanayaka · Dec 22, 2023 · a640a70 · a640a70
1 parent 9ad319a
commit a640a70
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/include/raft.h b/include/raft.h
@@ -672,6 +672,7 @@ struct raft_update
 #define RAFT_UPDATE_ENTRIES 1 << 2
 #define RAFT_UPDATE_SNAPSHOT 1 << 3
 #define RAFT_UPDATE_MESSAGES 1 << 4
+#define RAFT_UPDATE_STATE 1 << 5
 
 /**
  * version field MUST be filled out by user.

diff --git a/src/convert.c b/src/convert.c
@@ -22,6 +22,7 @@ static void convertSetState(struct raft *r, unsigned short new_state)
      * respect to the paper we have an additional "unavailable" state, which is
      * the initial or final state. */
     tracef("old_state:%u new_state:%u", r->state, new_state);
+    assert(r->state != new_state);
     assert((r->state == RAFT_UNAVAILABLE && new_state == RAFT_FOLLOWER) ||
            (r->state == RAFT_FOLLOWER && new_state == RAFT_CANDIDATE) ||
            (r->state == RAFT_CANDIDATE && new_state == RAFT_FOLLOWER) ||
@@ -31,6 +32,7 @@ static void convertSetState(struct raft *r, unsigned short new_state)
            (r->state == RAFT_CANDIDATE && new_state == RAFT_UNAVAILABLE) ||
            (r->state == RAFT_LEADER && new_state == RAFT_UNAVAILABLE));
     r->state = new_state;
+    r->update->flags |= RAFT_UPDATE_STATE;
 }
 
 /* Clear follower state. */