Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #100

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Minor fixes #100

merged 6 commits into from
Feb 13, 2024

Conversation

tbody-cfs
Copy link
Contributor

@tbody-cfs tbody-cfs commented Nov 13, 2023

Several small clean-ups.

  1. Use numpy instead of math library in several places.
  2. Minor doc-string tidying
  3. Update coil properties when setting properties on a circuit.
  4. Smoothly extrapolate the q-profile to the axis and separatrix.

@tbody-cfs tbody-cfs mentioned this pull request Nov 13, 2023
@@ -98,32 +98,6 @@ def __getitem__(self, name):
if label == name:
return coil
raise KeyError("Circuit does not contain coil with label '{0}'".format(name))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these getters and setters not needed on circuits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops — sorry — that commit shouldn't have been there. I've removed this now, thanks!

Copy link
Collaborator

@bendudson bendudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the long delay

@bendudson bendudson merged commit f7f8823 into freegs-plasma:master Feb 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants