Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: IMAS(IDS) via OMAS #94

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

kripnerl
Copy link
Contributor

@kripnerl kripnerl commented Apr 17, 2023

The first implementation of the first part of the IMAS IDS reader

This pull request server is more for discussion - it is not ready yet. Please let me know what you think about this approach and what should this pull request contains.

OMAS package serves as a thin layer between the IMAS database and the world. It allows interfacing the data to various formats. Therefore, I am using it to implement this code.

TODO:

  • Add multi-coil test
  • Read the first wall
  • Read circuit description
  • Construct complete freegs.Machine from the IDS.
  • Read sensors.
  • Properly test.
  • coil current slices
  • check ids control section and find compatibility
  • Write to documentation list of supported (required fields)

@kripnerl kripnerl mentioned this pull request Apr 17, 2023
@bendudson
Copy link
Collaborator

This would be a great feature to have. Thanks @kripnerl !
What is the recommended way to test this? Does OMAS have inputs that we could include in an automated test?

@kripnerl
Copy link
Contributor Author

This would be a great feature to have. Thanks @kripnerl ! What is the recommended way to test this? Does OMAS have inputs that we could include in an automated test?

I am currently using ods = omas.ods_sample(), and I will test it on our created machine description. I also plan to extend the feature and create some "synthetic" tokamak in OMAS description with all the features (including circuits and multicoils). The sample includes only a simple rectangular coil and a shaped coil. Eventually, I can create a pull request to OMAS to include this extended example. I assume it will be appreciated.

@kripnerl kripnerl changed the title Draft: Feature: IMAS(IDS) via OMAS Feature: IMAS(IDS) via OMAS Apr 20, 2023
@kripnerl
Copy link
Contributor Author

Ok, it seems to me it is ready for review. Please answer me questions I left in #95 . Specifically, please check whether I treat the filamentary coil properly.

This implementation is quite minimalistic, but for me, it fulfils most of my needs. One could read a lot of other structures supported by FreeGS (sensors, constraints, equilibrium)... At least reading/saving equilibria is on my todo list. But I assume it can be done in other MR.

I will also not be available next week, therefore I will able to implement review comments just after that.

@kripnerl
Copy link
Contributor Author

kripnerl commented Apr 21, 2023

Since I do not have any connection to any IMAS db at the moment. May I ask somebody, who do have gateway or iter account to try to load something? How to are here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants