Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipacert: Revoking with removeFromCRL should be handled as cert release #1323

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rjeffman
Copy link
Member

@rjeffman rjeffman commented Dec 5, 2024

When a revoked certificate with reason 6 (certificateHold) is revoked with reason 8 (removeFromCRL), the effect is that the certificate is valid again, as it is the same procedure as 'state: release'.

This is, at least, the behavior with IPA CLI comands, which is implemented by this patch.

A new test is added to verify this behavior:

tests/cert/test_cert_remove_hold_with_removeFromCRL.yml

Fixes RHEL-70021

When a revoked certificate with reason 6 (certificateHold) is revoked
with reason 8 (removeFromCRL), the effect is that the certificate is
valid again, as it is the same procedure as 'state: release'.

This is, at least, the behavior with IPA CLI comands, which is
implemented by this patch.

A new test is added to verify this behavior:

    tests/cert/test_cert_remove_hold_with_removeFromCRL.yml
Copy link
Member

@t-woerner t-woerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-woerner t-woerner merged commit 73160a0 into freeipa:master Dec 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants