Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic helm chart #408

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat: basic helm chart #408

merged 4 commits into from
Jul 25, 2024

Conversation

0xlildoudou
Copy link
Contributor

Hi,

I have write a simple Helm Chart for Kubernetes integration because i couldn't find the deployment procedure in the documentation.
https://docs.freelabz.com/in-depth/deployment#kubernetes

It works for closed clusters (no port opening in the cluster). You therefore need to start a shell in the “secator-manager” pod.

I'm available on Twitter/X (@lildoudou_) for improvements :)

@ocervell
Copy link
Contributor

ocervell commented Jun 4, 2024

Thanks for this ! Indeed we have some k8s manifests that we are using internally, but haven't had the time to clean them up for publishing yet.

Give me some time and I will review this ;)

@0xlildoudou
Copy link
Contributor Author

Thanks :)

@ocervell
Copy link
Contributor

ocervell commented Jul 5, 2024

Apart from the typo namager --> manager, it looks fine to me.

@0xlildoudou
Copy link
Contributor Author

Hi @ocervell ,

I have change my error

@ocervell
Copy link
Contributor

I've tested it on Minikube and it's working great ! Thank you so much for contributing to secator.

I'm going to merge this soon.

Here are potential improvements that could be made in the future:

  • Make an optional dependency on Redis Bitnami chart (thus removing the redis-service.yaml and redis.yaml)
  • Make an optional dependency on RabbitMQ Bitnami chart (to supporter another broker)
  • Make an optional dependency on MongoDB Bitnami chart (to support the mongodb addon)
  • Make a ConfigMap to customize secator's configuration config.yml file
  • Add an HPA for worker autoscaling (create new workers depending on the size of the Redis queue)
  • Add resources / requests limits to secator deployments

Cheers !!

@0xlildoudou
Copy link
Contributor Author

Hi,

Thanks 😀

don't worry, I'll be able to make changes when I have time 😁

@ocervell ocervell merged commit 6b2f84f into freelabz:main Jul 25, 2024
8 checks passed
@0xlildoudou 0xlildoudou deleted the k8s branch July 26, 2024 15:23
ocervell added a commit that referenced this pull request Aug 1, 2024
🤖 I have created a release *beep* *boop*
---


## [0.6.0](v0.5.2...v0.6.0)
(2024-07-25)


### Features

* add duplicate finder to mongodb hooks
([#409](#409))
([fb0e11c](fb0e11c))
* basic helm chart
([#408](#408))
([6b2f84f](6b2f84f))


### Bug Fixes

* Dockerfile broken apt install
([#407](#407))
([c023279](c023279))
* **tasks:** duplicate meta opt entry
([#401](#401))
([ae56aa6](ae56aa6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants