feat(eyecite): Fix california style #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These complex styles were failing with square brackets and years before the citation. Also addressed an issue with extra running too long and simplified the check for parallel citations
Change type hint move is parallel to fullcase citation
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 6 losses. Click here to see details.
Time Chart
Generated Files |
grossir
reviewed
Mar 6, 2025
| @@ -314,3 +314,6 @@ def short_cite_re(regex): | |||
| \ ? | |||
| {PARENTHETICAL_REGEX} | |||
| """ | |||
|
|
|||
| # A simple regex to check if year precedes citation | |||
| DEFENDNAT_YEAR_REGEX = r"(?P<defendant>.*)\s\((?P<year>\d{4})\)$" | |||
There was a problem hiding this comment.
typo: DEFENDNAT_YEAR_REGEX
should be DEFENDANT_YEAR_REGEX
| ) | ||
|
|
||
| # d this conclusion is supported by People v. Beach (1983) 147 Cal.App.3d 612 [195 Cal.Rptr. 381] (relocation away from home community as |
|
|
||
| Returns: None | ||
| """ | ||
| if self.full_span_start == preceding.full_span_start: |
There was a problem hiding this comment.
you are removing the self.full_span_end == preceding.full_span_end condition, is that desired?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These complex styles were failing with square brackets and years before the citation. Also addressed
an issue with extra running too long and
simplified the check for parallel citations
Meant to address complex citation patterns #185
This does not address California parentheticals