Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opinions.united_states_backscrapers folder excluded from tests #1087

Open
grossir opened this issue Jul 23, 2024 · 1 comment
Open

opinions.united_states_backscrapers folder excluded from tests #1087

grossir opened this issue Jul 23, 2024 · 1 comment

Comments

@grossir
Copy link
Contributor

grossir commented Jul 23, 2024

All scrapers in this folder are excluded from tests, notably test_ScraperExampleTest and test_ScraperExtractFromTextTest which may lead to errors when developing.

Also, federal_district and federal_appellate folders have HTML files per each scraper inside them, which does not follows the conventions in other parts of juriscraper of having the examples file in a different folder. This may lead to confusion to new developers / volunteers

grossir added a commit to grossir/juriscraper that referenced this issue Jul 23, 2024
Solves freelawproject#1087

- merge some backscrapers than can be easily merged with their parent scraper: ex bia
- include scrapers in united_states_backscrapers in test_ScraperExampleTest and test_ScraperExtractFromTextTest
@mlissner
Copy link
Member

Definitely should fix the example files so they're consistent.

I'm not sure it's worth fixing the backscrapers though. The idea, historically, was always that they were one-off tools, and so if they worked the one time, then they were fine — no tests needed. But I could see how if we're doing more backscraping, having tests would make sense. What do you suggest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants