feat(NewOpinionSite): support returning nested data structures #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dicts - create new base class for OpinionSite - add example for new deferring objects on `nev` - add example of json validation
- add jsonschema dependencies - create JSON Schemas for each scraped object, corresponding to courtlistener's Django Models - validate scraped data using JSONSchemaValidator - support nested objects data structures, which allow passing OpinionClusters to caller - nested objects also make it easier to pass previously unscraped objects to CL, like OriginatingCourtInformation - found an easy way to test secondary pages - update `tex` scraper to the new scraper class
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: juriscraper/opinions/united_states/state/tex.py
Did you find this useful? React with a 👍 or 👎 |
8 tasks
Also, update test files
Update texapp_1 through texapp_14 classes, and example files
for more information, see https://pre-commit.ci
Add tests for required properties, for types and formats, and for additional properties, to ensure the validator and the schemas work as expected Related to freelawproject#838
Add rfc3339 and rfc3986 dependencies
Deferred values are now collected explicitly, in 2 stages: - getting a deferred download_url - getting other deferred values Since download_url is needed for duplicate checking, it needs to be collected before the checking happens. After this check, we can collect other deferred values. Solves freelawproject#856
Solves: freelawproject#937 Scraper now goes into case page to look for opinion document when it is not linked on the search results page. This is done in a deferred way, also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #883
texscraper to the new scraper class (Related to Texas Supreme and Appellate scrapers enhacements #902 )