Use 'switch' instead of 'if' to check the logFormat. Return error if …

…the value is not valid
freenowtech · Nov 5, 2024 · 2e1fc41 · 2e1fc41
1 parent d3562a1
commit 2e1fc41
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/cmd/slo_exporter.go b/cmd/slo_exporter.go
@@ -100,9 +100,10 @@ func setupLogger(logLevel string, logFormat string) (*logrus.Logger, error) {
 		return nil, err
 	}
 
-	if logFormat != "json" && logFormat != "text" {
-		logFormat = "text"
-		logrus.Warningf("invalid log format '%s', using 'text' instead", logFormat)
+	switch logFormat {
+	case "json", "text":
+	default:
+		return nil, fmt.Errorf("invalid log format '%s', must be 'json' or 'text'", logFormat)
 	}
 
 	newLogger := logrus.New()