CI: Update Artifact actions to v4 #120

o01eg · 2024-11-13T17:52:21Z

No description provided.

o01eg · 2024-11-15T20:18:27Z

Yes, macos-11 is dropped, and I'm not sure what happening with Windows.

o01eg · 2024-12-23T13:28:27Z

@geoffthemedio SDL heavily changed installation so new things installed. Also looks like CMake is updated too and shows warnings about compatibility.

Vezzra

I can build the SDK, but I can't build FO with it. Whether I use the SDK I built manually, or try to build the test commit on your master branch (d69a4a24812c73274c8cda233f78e131645c3450), I get build errors, basically this one error multiple times:

In file included from /Users/user/SoftwareProjekte/FO/main/src/client/human/chmain.cpp:1:
In file included from /Users/user/SoftwareProjekte/FO/main/src/client/human/GGHumanClientApp.h:6:
In file included from /Users/user/SoftwareProjekte/FO/main/src/client/human/../../UI/SDLGUI.h:9:
In file included from /Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/SDL2.framework/Headers/SDL.h:32:
In file included from /Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/SDL2.framework/Headers/SDL_main.h:25:
/Users/user/SoftwareProjekte/FO/main/build/dep/Frameworks/SDL2.framework/Headers/SDL_stdinc.h:31:10: fatal error: 'SDL_config.h' file not found
#include "SDL_config.h"

o01eg · 2024-12-23T14:36:55Z

Yes, I'm trying to disable SDL framework as it's don't work correctly after installation changes in SDL.

o01eg · 2024-12-23T14:51:52Z

Latest try from https://github.com/freeorion/freeorion-sdk/actions/runs/12468283058 should work, but you need to add into FreeOrion's CMakeLists.txt

        COMMAND
           ${CMAKE_COMMAND} -E copy_if_different "$<TARGET_FILE:SDL::SDL>" "$<TARGET_FILE_DIR:freeorion>/../SharedSupport"

o01eg · 2024-12-23T15:54:28Z

Another try https://github.com/o01eg/freeorion-sdk/releases/tag/v17

o01eg · 2024-12-23T16:58:39Z

MacOS and Windows builds pass https://github.com/o01eg/freeorion/actions/runs/12469666979/job/34803281345

Vezzra

I can now build FO (I build commit 5a787653769b836a6d499b2fdd62c6df3929ac56 from your repo), but the app crashes on startup. Apparently, it can't load libSDL2-2.0.0.dylib:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               FreeOrion [2663]
Path:                  /Volumes/VOLUME/FreeOrion.app/Contents/MacOS/FreeOrion
Identifier:            org.freeorion.FreeOrion
Version:               0.5.1+ (build 2024-12-23.5a78765) (0.5.1+ o01eg-master (build 2024-12-23.5a78765))
Code Type:             X86-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2024-12-24 10:22:49.6584 +0100
OS Version:            macOS 12.6 (21G115)
Report Version:        12
Bridge OS Version:     6.6 (19P6067)
Anonymous UUID:        DBE14CFB-5083-F51E-3D62-E711C220B917


Time Awake Since Boot: 6900 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace DYLD, Code 1 Library missing
Library not loaded: '@rpath/libSDL2-2.0.0.dylib'
Referenced from: '/Volumes/VOLUME/FreeOrion.app/Contents/MacOS/FreeOrion'
Reason: tried: '' (no such file), '' (no such file), '' (no such file), '' (no such file), '' (no such file), '' (no such file)
(terminated at launch; ignore backtrace)

Thread 0 Crashed:
0   dyld                          	       0x10ff0598e __abort_with_payload + 10
1   dyld                          	       0x10ff1ba72 abort_with_payload_wrapper_internal + 80
2   dyld                          	       0x10ff1baa4 abort_with_payload + 9
3   dyld                          	       0x10fec9699 dyld4::halt(char const*) + 615
4   dyld                          	       0x10fec55b5 dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 3995
5   dyld                          	       0x10fec44e4 start + 388


Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000002000209  rbx: 0x0000000000000000  rcx: 0x00007ff7bae8d668  rdx: 0x00007ff7bae8dad0
  rdi: 0x0000000000000006  rsi: 0x0000000000000001  rbp: 0x00007ff7bae8d6b0  rsp: 0x00007ff7bae8d668
   r8: 0x00007ff7bae8d6d0   r9: 0x0000000000000000  r10: 0x0000000000000069  r11: 0x0000000000000246
  r12: 0x0000000000000069  r13: 0x00007ff7bae8dad0  r14: 0x0000000000000001  r15: 0x0000000000000006
  rip: 0x000000010ff0598e  rfl: 0x0000000000000246  cr2: 0x0000000105f62000
  
Logical CPU:     0
Error Code:      0x02000209 
Trap Number:     133


Binary Images:
       0x10febf000 -        0x10ff2afff dyld (*) <71febccd-d9dc-3599-9971-2b3407c588a8> /usr/lib/dyld

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=47.1M resident=0K(0%) swapped_out_or_unallocated=47.1M(100%)
Writable regions: Total=9428K written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=9428K(100%)

                                VIRTUAL   REGION 
REGION TYPE                        SIZE    COUNT (non-coalesced) 
===========                     =======  ======= 
STACK GUARD                       56.0M        1 
Stack                             8192K        1 
VM_ALLOCATE                         12K        3 
__DATA                             592K        9 
__DATA_CONST                       944K        5 
__LINKEDIT                        21.5M        7 
__TEXT                            25.6M        5 
dyld private memory               1024K        1 
===========                     =======  ======= 
TOTAL                            113.6M       32

o01eg · 2024-12-24T14:58:13Z

@Vezzra Did you make changes in FreeOrion's CMakeLists.txt to copy libSDL2-2.0.0.dylib into SharedSupport folder?

o01eg · 2024-12-24T20:11:00Z

Oh, I got it built and published as artifact https://github.com/o01eg/freeorion/actions/runs/12485231351

I have no idea but somehow it links to libSDL2-2.0.0.dylib but copies libSDL2.dylib to SharedSupport folder.

o01eg · 2024-12-25T05:02:53Z

Now I see only libSDL2.dylib in SDK~~, @Vezzra could you try again?~~

Edit: Which is broken.

o01eg · 2024-12-25T07:17:12Z

@Vezzra Lastest try from https://github.com/freeorion/freeorion-sdk/actions/runs/12490346595/artifacts/2360950457 looks better, could you check it?

CI built something https://github.com/o01eg/freeorion/actions/runs/12491108076/artifacts/2361099703 not sure if it works

Vezzra · 2024-12-25T11:08:06Z

@Vezzra Did you make changes in FreeOrion's CMakeLists.txt to copy libSDL2-2.0.0.dylib into SharedSupport folder?

The line you mentioned above was already there, so I didn't make any changes to CMakeLists.txt.

Vezzra

Success! I built commit adda0b1 ("Test 20 SDK") of your repo, and have been able to start FO without crash. Also a quick start game worked normally.

The build process pulled in the right FO SDK (FreeOrionSDK_20_Clang-MacOSX-10.15-x86_64), so I guess that means the issues have been fixed.

o01eg · 2024-12-25T11:28:26Z

@geoffthemedio Does the latest Windows SDK works for you?

geoffthemedio · 2024-12-25T20:25:07Z

@geoffthemedio Does the latest Windows SDK works for you?

Self built or specifically the download?

o01eg · 2024-12-26T02:46:31Z

I suppose downloaded as we mostly use SDKs built by Github Actions.

geoffthemedio · 2024-12-26T10:23:02Z

Downloaded SDK (x64, v143) for Windows built and seems to run OK.

11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:85 : Dependency versions from headers:
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : Boost: 1_83
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : FreeType: 2.9.0
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : GLEW: 2.2.0
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : PNG: 1.6.37
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : Python: 3.9.10
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : SDL: 2.26.0
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : libvorbis: Xiph.Org libVorbis 1.3.5
11:25:25.132012 {0x00001b8c} [info] client : DependencyVersions.cpp:88 : zlib: 1.2.11

o01eg added the enhancement label Nov 13, 2024

o01eg requested a review from geoffthemedio November 13, 2024 17:52

This comment was marked as outdated.

Sign in to view

o01eg force-pushed the ci-update-artifact-v4 branch 12 times, most recently from e863616 to 4dd4c31 Compare December 22, 2024 18:15

o01eg added 14 commits December 22, 2024 23:12

CI: Update Artifact actions to v4

40722bd

Update MacOS runner from 11 to 13

a596d0c

Upload python library artifact once for Android

148d49a

Fix boost toolset issue

fd08da0

Update SDL to 2.0.14 and output applied patch

6a9a0ae

Update SDL to 2.0.16

1eebe03

Update SDL to 2.0.18

e055b0d

Update SDL to 2.0.20

01b9da1

Update SDL to 2.0.22

9d79590

Update SDL to 2.24.0

abe8aba

Fix artifact names collision for Android

3c67613

Update SDL to 2.24.2

b35e721

Update SDL to 2.26.0

670ff26

Fix artifact names for Windows

e427d08

o01eg force-pushed the ci-update-artifact-v4 branch from 37e360e to 4611727 Compare December 23, 2024 09:59

Try to add missing SDL_revision.h and SDL_config.h headers

5289a77

o01eg force-pushed the ci-update-artifact-v4 branch from 4611727 to 5289a77 Compare December 23, 2024 10:09

o01eg force-pushed the ci-update-artifact-v4 branch from 0dfcbe2 to 53e0c0d Compare December 23, 2024 13:39

Vezzra requested changes Dec 23, 2024

View reviewed changes

Try to disable SDL Framework installation

98fff57

o01eg force-pushed the ci-update-artifact-v4 branch from 53e0c0d to 98fff57 Compare December 23, 2024 14:22

o01eg requested a review from Vezzra December 23, 2024 14:50

Vezzra requested changes Dec 24, 2024

View reviewed changes

o01eg requested a review from Vezzra December 24, 2024 14:58

o01eg force-pushed the ci-update-artifact-v4 branch from adbdd85 to 7c2927f Compare December 25, 2024 05:51

Fix so-names for SDL on MacOS

a6f1d27

o01eg force-pushed the ci-update-artifact-v4 branch from 7c2927f to a6f1d27 Compare December 25, 2024 06:40

Vezzra approved these changes Dec 25, 2024

View reviewed changes

o01eg merged commit 7293ba9 into freeorion:master Dec 26, 2024
7 checks passed

o01eg deleted the ci-update-artifact-v4 branch December 26, 2024 11:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Update Artifact actions to v4 #120

CI: Update Artifact actions to v4 #120

o01eg commented Nov 13, 2024

This comment was marked as outdated.

o01eg commented Nov 15, 2024

o01eg commented Dec 23, 2024

Vezzra left a comment

o01eg commented Dec 23, 2024

o01eg commented Dec 23, 2024 •

edited

Loading

o01eg commented Dec 23, 2024

o01eg commented Dec 23, 2024

Vezzra left a comment

o01eg commented Dec 24, 2024

o01eg commented Dec 24, 2024

o01eg commented Dec 25, 2024 •

edited

Loading

o01eg commented Dec 25, 2024 •

edited

Loading

Vezzra commented Dec 25, 2024

Vezzra left a comment

o01eg commented Dec 25, 2024

geoffthemedio commented Dec 25, 2024

o01eg commented Dec 26, 2024

geoffthemedio commented Dec 26, 2024 •

edited

Loading

CI: Update Artifact actions to v4 #120

CI: Update Artifact actions to v4 #120

Conversation

o01eg commented Nov 13, 2024

This comment was marked as outdated.

o01eg commented Nov 15, 2024

o01eg commented Dec 23, 2024

Vezzra left a comment

Choose a reason for hiding this comment

o01eg commented Dec 23, 2024

o01eg commented Dec 23, 2024 • edited Loading

o01eg commented Dec 23, 2024

o01eg commented Dec 23, 2024

Vezzra left a comment

Choose a reason for hiding this comment

o01eg commented Dec 24, 2024

o01eg commented Dec 24, 2024

o01eg commented Dec 25, 2024 • edited Loading

o01eg commented Dec 25, 2024 • edited Loading

Vezzra commented Dec 25, 2024

Vezzra left a comment

Choose a reason for hiding this comment

o01eg commented Dec 25, 2024

geoffthemedio commented Dec 25, 2024

o01eg commented Dec 26, 2024

geoffthemedio commented Dec 26, 2024 • edited Loading

o01eg commented Dec 23, 2024 •

edited

Loading

o01eg commented Dec 25, 2024 •

edited

Loading

o01eg commented Dec 25, 2024 •

edited

Loading

geoffthemedio commented Dec 26, 2024 •

edited

Loading