Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StatePredicate & State design & Expectation#{w,t}hen docs #427

Closed
wants to merge 7 commits into from
Closed

Update StatePredicate & State design & Expectation#{w,t}hen docs #427

wants to merge 7 commits into from

Conversation

nitishr
Copy link
Contributor

@nitishr nitishr commented Nov 25, 2019

Address #425 by updating first the design of State{,Predicate} and then the documentation of Expectation#{w,t}hen

@nitishr nitishr force-pushed the expectation-when-then branch from 3fb65ee to 4c888da Compare November 25, 2019 23:06
@nitishr nitishr force-pushed the expectation-when-then branch from 40f1bd4 to 80a656e Compare November 25, 2019 23:32
@floehopper floehopper self-assigned this Dec 22, 2019
floehopper added a commit that referenced this pull request Dec 22, 2019
@floehopper
Avoid rubocop comments appearing in YARD-generated docs
d8019ee 
By using the single-line version.

Note that the comment still shows up in the source code in the
documentation, but since this is hidden by default, I think this is less
of an issue.

My attention was drawn to this by @nitishr in a commit in #427.
@floehopper
Copy link
Member

@nitishr Thanks for this. I've done some work on getting this merged, but it's still a work in progress.

@nitishr nitishr requested a review from floehopper January 16, 2020 14:52
@floehopper
Copy link
Member

I've finally got round to finishing up my work on this. I've pushed the tweaked changes in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper Awaiting requested review from floehopper

Assignees

@floehopper floehopper

Labels
documentation refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitishr @floehopper