stubbee -> stubba_object, mock_owner -> stubbee #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubbee is the thing that's stubbed - more specifically, the object on which .stubs or .mocks is called. Therefore, it's also the object that holds a reference to mocha. That's why it was called mock_owner earlier. stubba_object is the object through which we get hold of the stubba_class on which stubbed methods reside. In case of AnyInstance, that class is the stubba_object itself, while in case of Instance, it's the singleton class of the stubba_object.
nitishr
force-pushed
the
stubee-mock-owner-naming
branch
from
bd9c51c
to
e28d7f7
Compare
|
@nitishr Sorry for the slow response - I've been busy with client work. Thanks for all your ongoing work on Mocha. I'll take a look at all your open PRs as soon as I can. |
|
Sure, no rush. If I can do anything to make it easier, please let me know. |
This was referenced Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename: stubbee -> stubba_object, mock_owner -> stubbee
stubbee is the thing that's stubbed - more specifically, the object on
which .stubs or .mocks is called. (Therefore, it's also the object that
holds a reference to mocha. That's why it was called mock_owner earlier.
But that's an implementation detail that doesn't have to reflect in the
naming)
stubba_object is the object through which we get hold of the
stubba_class on which stubbed methods reside. In case of AnyInstance,
that class is the stubba_object itself, while in case of Instance, it's
the singleton class of the stubba_object.
This is consistent with the meaning and usage of stubba_object and
stubba_class methods in ObjectMethods and AnyInstance.