Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note and example for yield with no args #496

Closed
wants to merge 1 commit into from
Closed

Add note and example for yield with no args #496

wants to merge 1 commit into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 1, 2020

Closes #495

@andyw8 andyw8 mentioned this pull request Nov 1, 2020
Closed
@floehopper
Copy link
Member

@andyw8 Thanks for opening this PR. I'm afraid I'm really busy at the moment, but I promise I'll get to it as soon as I can!

nitishr
nitishr reviewed Nov 10, 2020
View reviewed changes
lib/mocha/expectation.rb Show resolved Hide resolved
lib/mocha/expectation.rb Show resolved Hide resolved
@floehopper
Copy link
Member

@andyw8 Sorry for the very slow response - I've just been really busy with work. I've tweaked the changes in this PR a bit and merged them in d590812. Closing.

@floehopper floehopper closed this Nov 27, 2020
@andyw8
Copy link
Contributor Author

andyw8 commented Nov 27, 2020

Thanks!

@floehopper
Copy link
Member

Apologies - I merged this into the wrong branch. I've now added it into main in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper floehopper left review comments

@nitishr nitishr nitishr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stub and yield passed block
3 participants
@andyw8 @floehopper @nitishr