Merge pull request #19 from freescout-helpdesk/analysis-8A532V

Apply fixes from StyleCI

app/Conversation.php

@@ -289,7 +289,7 @@ public function setStatus($status, $user = null)
 
     /**
      * Set conversation user and all related fields.
-     * 
+     *
      * @param int $user_id
      */
     public function setUser($user_id)

app/Http/Controllers/ConversationsController.php

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers;
 
 use App\Conversation;
-use Illuminate\Http\Request;
 
 class ConversationsController extends Controller
 {

app/Http/Controllers/SecureController.php

@@ -3,10 +3,10 @@
 namespace App\Http\Controllers;
 
 use App\ActivityLog;
-use Illuminate\Http\Request;
 use App\Conversation;
 use App\Events\ConversationStatusChanged;
 use App\Events\ConversationUserChanged;
+use Illuminate\Http\Request;
 
 class SecureController extends Controller
 {
@@ -92,7 +92,7 @@ public function ajax(Request $request)
             case 'conversation_change_user':
                 $conversation = Conversation::find($request->conversation_id);
 
-                $new_user_id = (int)$request->user_id;
+                $new_user_id = (int) $request->user_id;
 
                 if (!$conversation) {
                     $response['msg'] = 'Conversation not found';

app/Mailbox.php

@@ -4,7 +4,6 @@
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Hash;
-use App\User;
 
 class Mailbox extends Model
 {
@@ -210,7 +209,7 @@ public function updateFoldersCounters()
                     ->where('status', Conversation::STATUS_ACTIVE)
                     ->where('user_id', $folder->user_id)
                     ->count();
-                // todo: starred conversations counting
+            // todo: starred conversations counting
             } else {
                 $folder->active_count = $folder->conversations()
                     ->where('status', Conversation::STATUS_ACTIVE)
@@ -268,6 +267,7 @@ public function usersHavingAccess()
     {
         $users = $this->users;
         $admins = User::where('role', User::ROLE_ADMIN)->get();
+
         return $users->merge($admins)->unique();
     }
 
@@ -278,6 +278,7 @@ public function userIdsHavingAccess()
     {
         $user_ids = $this->users()->pluck('users.id');
         $admin_ids = User::where('role', User::ROLE_ADMIN)->pluck('id');
+
         return $user_ids->merge($admin_ids)->unique()->toArray();
     }
 }

app/Thread.php

@@ -284,15 +284,15 @@ public static function statusCodeToName($status)
 
     /**
      * Get text for the assignee.
-     * 
+     *
      * @return string
      */
     public function getAssignedName()
     {
         if (!$this->user_id) {
-            return __("anyone");
+            return __('anyone');
         } elseif ($this->user_id == auth()->user()->id) {
-            return __("yourself");
+            return __('yourself');
         } else {
             return $this->user->getFullName();
         }