Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Node Service and Runtime with Async Backing and Updated Configurations #853

Merged
merged 78 commits into from
Nov 5, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 24, 2024

PR Type

Enhancement, Tests


Description

  • Enhanced node service with updated consensus and slot handling.
  • Implemented async backing migration with comprehensive tests.
  • Updated runtime configurations for block weights, slot durations, and vesting schedules.
  • Added new dependencies for parachain inherent and aura.
  • Improved logging in CI build workflow.

Changes walkthrough 📝

Relevant files
Enhancement
19 files
laos.rs
Update vesting configuration for predefined accounts         

node/src/chain_spec/laos.rs

  • Updated vesting configuration for predefined accounts.
+1/-2     
service.rs
Enhance node service with updated slot handling                   

node/src/service.rs

  • Added new imports for relay chain slot duration and validation code.
  • Modified slot duration handling and parachain inherent data.
  • Updated consensus start parameters.
  • +48/-22 
    lib.rs
    Update block weight constants and tests                                   

    primitives/src/lib.rs

  • Updated maximum block weight constants.
  • Adjusted block weight tests.
  • +14/-8   
    aura.rs
    Modify Aura configuration for slot handling                           

    runtime/laos/src/configs/aura.rs

    • Changed slot duration and allowed multiple blocks per slot.
    +3/-3     
    collective.rs
    Update collective configuration imports                                   

    runtime/laos/src/configs/collective.rs

    • Updated imports to include time constants.
    +4/-2     
    cumulus_parachain_system.rs
    Update parachain system configuration                                       

    runtime/laos/src/configs/cumulus_parachain_system.rs

  • Changed relay number check to monotonically increase.
  • Made relay chain slot duration public.
  • +4/-3     
    democracy.rs
    Update democracy configuration and tests                                 

    runtime/laos/src/configs/democracy.rs

  • Updated imports to include time constants.
  • Adjusted block number in tests.
  • +2/-3     
    election_phragmen.rs
    Update election phragmen configuration imports                     

    runtime/laos/src/configs/election_phragmen.rs

    • Updated imports to include time constants.
    +1/-2     
    evm.rs
    Update EVM configuration tests                                                     

    runtime/laos/src/configs/evm.rs

    • Increased block gas limit in tests.
    +1/-1     
    identity.rs
    Update identity configuration imports                                       

    runtime/laos/src/configs/identity.rs

    • Updated imports to include time constants.
    +1/-2     
    mod.rs
    Modify module visibility for parachain system                       

    runtime/laos/src/configs/mod.rs

    • Made cumulus parachain system configuration public.
    +1/-1     
    parachain_staking.rs
    Update parachain staking configuration                                     

    runtime/laos/src/configs/parachain_staking.rs

    • Adjusted slots per year calculation.
    +1/-1     
    scheduler.rs
    Update scheduler configuration imports                                     

    runtime/laos/src/configs/scheduler.rs

    • Updated imports to include normal dispatch ratio.
    +1/-2     
    timestamp.rs
    Update timestamp configuration                                                     

    runtime/laos/src/configs/timestamp.rs

    • Set minimum period to zero.
    +2/-2     
    treasury.rs
    Update treasury configuration imports                                       

    runtime/laos/src/configs/treasury.rs

    • Updated imports to include time constants.
    +1/-2     
    vesting.rs
    Update vesting configuration                                                         

    runtime/laos/src/configs/vesting.rs

    • Increased maximum vesting schedules.
    +1/-1     
    lib.rs
    Update runtime constants and implement Aura API                   

    runtime/laos/src/lib.rs

  • Updated block time constants.
  • Added Aura unincluded segment API implementation.
  • +15/-2   
    async_backing.rs
    Implement async backing migration with tests                         

    runtime/laos/src/migrations/async_backing.rs

  • Added migration logic for async backing.
  • Included tests for migration scenarios.
  • +756/-0 
    mod.rs
    Add async backing migration                                                           

    runtime/laos/src/migrations/mod.rs

    • Added async backing migration to migrations list.
    +4/-1     
    Tests
    2 files
    mod.rs
    Update runtime tests for block limits and vesting               

    runtime/laos/src/tests/mod.rs

  • Updated block and gas limit constants in tests.
  • Adjusted vesting schedule tests.
  • +3/-3     
    test-vesting.ts
    Update vesting tests for new configuration                             

    e2e-tests/tests/test-vesting.ts

    • Updated vesting test expectations.
    +1/-2     
    Documentation
    1 files
    download_polkadot.sh
    Update download script comments                                                   

    zombienet/download_polkadot.sh

    • Updated default download directory comment.
    +1/-1     
    Configuration changes
    1 files
    build.yml
    Enhance logging in build workflow                                               

    .github/workflows/build.yml

    • Added info logging to try-runtime steps.
    +2/-2     
    Dependencies
    4 files
    Cargo.toml
    Update dependencies for parachain inherent and aura           

    Cargo.toml

    • Added new dependencies for parachain inherent and aura.
    +4/-0     
    package-lock.json
    Update Truffle dependency version                                               

    e2e-tests/package-lock.json

    • Updated Truffle version.
    +1/-1     
    Cargo.toml
    Update node workspace dependencies                                             

    node/Cargo.toml

    • Added new workspace dependencies for relay chain and inherent.
    +3/-0     
    Cargo.toml
    Update runtime Cargo features                                                       

    runtime/laos/Cargo.toml

    • Added aura to std features.
    +2/-0     
    Miscellaneous
    1 files
    metadata15.golden
    Update runtime metadata                                                                   

    runtime/laos/src/tests/metadata15.golden

    • Updated metadata for runtime changes.
    +141/-80

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi dismissed stale reviews from luispdm and magecnion via ec9dab0 October 31, 2024 13:54
    @asiniscalchi asiniscalchi marked this pull request as draft October 31, 2024 14:32
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Async backing: Enhance Node Service and Runtime with Updated Consensus and Slot Handling Enhance Node Service and Runtime with Async Backing and Updated Configurations Nov 4, 2024
    Copy link

    github-actions bot commented Nov 4, 2024

    PR Description updated to latest commit (0050b26)

    @asiniscalchi asiniscalchi marked this pull request as ready for review November 4, 2024 17:33
    @asiniscalchi asiniscalchi linked an issue Nov 5, 2024 that may be closed by this pull request
    asiniscalchi and others added 3 commits November 5, 2024 11:09
    Co-authored-by: Luigi di Girolamo <17044119+luispdm@users.noreply.github.com>
    @asiniscalchi asiniscalchi merged commit ef83217 into main Nov 5, 2024
    8 of 9 checks passed
    @asiniscalchi asiniscalchi deleted the feature/active_async_backing branch November 5, 2024 10:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Enable Async Backing
    3 participants