Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance node service and update parachain configurations #830

Closed
wants to merge 28 commits into from

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 22, 2024

PR Type

enhancement, configuration changes


Description

  • Updated node service to use a fixed relay chain slot duration and introduced a state proof builder for parachain inherent data.
  • Defined a constant for maximum block weight in the primitives library.
  • Enabled multiple blocks per slot in the Aura configuration.
  • Modified relay number check to RelayNumberMonotonicallyIncreases in the parachain system configuration.
  • Set the minimum period to 0 in the timestamp configuration.
  • Changed the average expected block time to 6000 milliseconds.
  • Updated comments in the download script for clarity.
  • Added new dependencies for parachain inherent and relay chain in Cargo.toml files.

Changes walkthrough 📝

Relevant files
Enhancement
2 files
service.rs
Update node service for relay chain slot and state proof 

node/src/service.rs

  • Added imports for Slot and SlotDuration.
  • Replaced slot duration calculation with a fixed relay chain slot
    duration.
  • Introduced state proof builder for parachain inherent data.
  • +27/-10 
    lib.rs
    Define maximum block weight constant                                         

    primitives/src/lib.rs

  • Added WEIGHT_REF_TIME_PER_SECOND to imports.
  • Defined MAXIMUM_BLOCK_WEIGHT constant for block weight.
  • +8/-2     
    Configuration changes
    4 files
    aura.rs
    Enable multiple blocks per slot in Aura config                     

    runtime/laos/src/configs/aura.rs

    • Changed AllowMultipleBlocksPerSlot to true.
    +1/-1     
    cumulus_parachain_system.rs
    Modify relay number check in parachain system config         

    runtime/laos/src/configs/cumulus_parachain_system.rs

    • Updated relay number check to RelayNumberMonotonicallyIncreases.
    +2/-1     
    timestamp.rs
    Adjust minimum period in timestamp config                               

    runtime/laos/src/configs/timestamp.rs

    • Set MinimumPeriod to 0.
    +2/-2     
    lib.rs
    Update block time configuration                                                   

    runtime/laos/src/lib.rs

    • Changed MILLISECS_PER_BLOCK to 6000.
    +1/-1     
    Documentation
    1 files
    download_polkadot.sh
    Update download directory comment in script                           

    zombienet/download_polkadot.sh

    • Updated default download directory comment.
    +1/-1     
    Dependencies
    2 files
    Cargo.toml
    Add new dependencies for parachain and relay chain             

    Cargo.toml

    • Added new dependencies for parachain inherent and relay chain.
    +3/-0     
    Cargo.toml
    Update node workspace dependencies                                             

    node/Cargo.toml

  • Added workspace dependencies for parachain inherent and relay chain.
  • +3/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi
    Copy link
    Member Author

    /review

    Copy link

    PR Description updated to latest commit (528aeb0)

    @github-actions github-actions bot changed the title Release/active async backing Enhance node service and update parachain configurations Oct 22, 2024
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Update
    The removal of slot_duration and target_gas_price might affect the behavior of the system. Ensure that the new implementation with Slot and SlotDuration correctly replaces the old logic without unintended side effects.

    New Implementation
    The new patch for parachain inherent data creation involves several new dependencies and a significant change in logic. This should be carefully reviewed to ensure it integrates well with the existing system and does not introduce new bugs.

    Constants Redefinition
    The redefinition of MAXIMUM_BLOCK_WEIGHT using new constants should be checked for impacts on system performance and block processing times.

    Configuration Change
    The change in MinimumPeriod to 0 could have implications on the block timing and system stability. This needs thorough testing and validation.

    @asiniscalchi asiniscalchi linked an issue Oct 22, 2024 that may be closed by this pull request
    @tonimateos tonimateos linked an issue Oct 24, 2024 that may be closed by this pull request
    @asiniscalchi
    Copy link
    Member Author

    move here : #853

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants