Increase zombienet blocks per round to avoid invalid tx #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
asiniscalchi
approved these changes
Nov 26, 2024
luispdm
approved these changes
Nov 26, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to this Issue concerning the
pallet_session, each block where a new session starts deems all tx attempted to be included in it as invalid, which is specially annoying during zombienet testing as we need to track if those tx has been finalized. For testing purposes (til the mentioned issue is addressed), we increase the number of blocks per round, which implies an increase in the number of blocks per session, in order to 'dodge' those blocks.