Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to NetVips 1.2.4 and update to NetVips Native 8.10.0. #164

Closed
wants to merge 2 commits into from
Closed

Revert back to NetVips 1.2.4 and update to NetVips Native 8.10.0. #164

wants to merge 2 commits into from

Conversation

jsm174
Copy link
Collaborator

@jsm174 jsm174 commented Aug 27, 2020

These updates are based on @kleisauke linux branch at kleisauke@c34b840

This was in support of getting Visual Pinball Engine to run on Linux: kleisauke/net-vips#90

It restores NetVips back to 1.2.4 (instead of the custom NetVips.Unity fork) and uses NetVips Native 8.10.0.

It adds RuntimeIdentifier support to the project files and updates the PluginsDeploy target to copy platform specific DLLs (managed and native) to the Plugins folder.

Regardless of the platform being built on, to force all Plugins to be updated we should run:

dotnet build -c Release -r win-x64
dotnet build -c Release -r win-x86
dotnet build -c Release -r osx-x64
dotnet build -c Release -r linux-x64

The test projects (VisualPinball.Engine.Test, and VisualPinball.Unity.Test) have been updated from net472 to netcoreapp3.1

The github workflow has been updated to use dotnet for all platforms. (Previously it was using msbuild for OSX and Linux.)

dotnet build -c Release -r osx-x64
dotnet test -r osx-x64

GetTestPath() was updated to properly access the Fixtures~ directory, when running VisualPinball.Unity.Test test cases.

Unity.Burst.dll was added to Plugins\.unity to support QuadTree in VisualPinball.Unity.Test

Finally @kleisauke was added to the authors in all projects!

…p test projects to netcoreapp3.1. Fix GetTestPath() when running Unity tests from VS. Added Burst dependency. Add @kleisauke to authors.
@freezy freezy mentioned this pull request Aug 30, 2020
@freezy
Copy link
Owner

freezy commented Aug 30, 2020

Superseded by #170. Thanks again everyone involved!

@freezy freezy closed this Aug 30, 2020
@jsm174 jsm174 deleted the netvips-linux branch October 7, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants