Support deployPercentage in publish API
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Jun 5, 2024
fregante
reviewed
Jun 5, 2024
fregante
reviewed
Jun 5, 2024
|
let me know if there is anything else to improve (squashing commits for example). |
fregante
approved these changes
Jun 5, 2024
fregante
changed the title
deployPercentage in publish API
fregante
reviewed
Jun 5, 2024
| @@ -49,7 +49,8 @@ store.uploadExisting(myZipFile, token).then(res => { | |||
| ```javascript | |||
| const target = 'default'; // optional. Can also be 'trustedTesters' | |||
| const token = 'xxxx'; // optional. One will be fetched if not provided | |||
| store.publish(target, token).then(res => { | |||
| const deployPercentage = 25; // optional. Will default to 100%. | |||
| store.publish({ target, deployPercentage, token }).then((res) => { | |||
There was a problem hiding this comment.
On second thought, I'm not ready to release a breaking version. I already have a partial rewrite in progress and I'd want to release that instead. See #84
Can you revert this API to accept a third parameter?
There was a problem hiding this comment.
So it should be changed this way if I understand correctly:
store.publish(target, token, deployPercentage)
|
v3.1.0 is out, let me know how it goes. Could you also add a flag to https://github.com/fregante/chrome-webstore-upload-cli? |
|
Here is the CLI update MR: fregante/chrome-webstore-upload-cli#83 |
|
Just a quick comment to tell you that I have had the opportunity to test it and it worked ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding support for the deployPercentage parameter when calling the publish API.