-
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
There are a lot of unrelated changes (the action.yml formatting isn’t “better” and is unrelated) and the file in |
|
… + revert formatting in `action.yml`
Unfortunately this doesn’t work with GitHub Actions. They want a pre-built file committed to the repo. Also no need to force push. Just add commits normally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add some tests to ensure it works?
And how? |
There’s a file that ends with .test.js. Look at how the other features are tested a create similar tests for this new option. It should test for both a keyword and some custom formats |
I added date test, but after I run it it except a error on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! I’ll leave it here a day or 2 and then merge it if no one complains
I added more date formats, especially for the date without leading zero and also for testing in |
Please undo, git date formats are good enough. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor nits, looks good to me.
I remade whole test, because custom date format check is failing. It was failing because |
Not a bad idea, I dislike mocks for this exact reason, they give a false sense of security. |
Could you merge this pull request now, so I can open another, that fixes another issue? |
Thank you @BelKed! |
Resolves #30.