This repository has been archived by the owner on Apr 15, 2023. It is now read-only.
Restore Node 12 support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
fregante
commented
Oct 4, 2021
fregante
commented
- Fixes release-with-changelog@main does not load after update to node16 #50
|
The Node ecosystem really pulled a Python 3 with regards to ESM support 🤦
⬆️ same feeling. |
|
This was my fault, I didn't see that Node16 isn't supported on GHA (????), but https://github.com/fregante/release-with-changelog/issues/52… I don't know what's that about, so I just reverted everything. Feels like a lot of issues go away if we stop being so bleeding-edge. It's unfortunate that ESM is "bleeding edge" in 2021 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.