Add support for Manifest v3 #28
Conversation
Update all module dependencies to the latest versions, as discussed in: fregante#19 (comment)
index.ts
Outdated
| const optionalHosts = optionalPermissions?.filter(permission => /<all_urls>|\*/.test(permission)); | ||
| const optHostPermsKey = manifest.version === '2' ? 'optional_permissions' : 'optional_host_permissions'; | ||
| // @types/chrome is missing a type for optional_host_permissions: | ||
| // https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/68051 |
There was a problem hiding this comment.
|
@aspiers how does it look? I published a beta version as v4.1.0-0 that you can install directly. One thing I'd avoid in this PR is to update the dependencies (except maybe @types/chrome if necessary). This way I can release it as a minor version for now |
Will test and let you know!
Ah sorry, I thought you'd asked for that, but looking back at that comment I see you probably meant something else. |
|
Oh yeah I did ask for it, thinking that those dependencies were recently updated to improve MV3 compat, but that isn't the case. The dev dependencies also change the output so I'll skip them for now |
|
Still testing this and trying to untangle various issues as mentioned in #29 (comment) |
|
This works for me. The other issues I see are unrelated to MV3 |
This is only lightly tested on Chrome with a v3 manifest, not with any v2 manifests or other browsers such as Firefox.