-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snmp_profiles: fixes wrong values and unify OIDs #789
Conversation
66e7b5a
to
b3872da
Compare
d7d3947
to
69b198b
Compare
Im running again into
So we have the option of going back to index numbers or have some errors. I still need to check if this errors result in no data being sent in general. Maybe we can just tell collectd in general to stop reporting errors :D |
I decided for supressing all errors of collectd in favour of having nicer names in monitoring. This means label of ports that are used at a location should be unique |
69b198b
to
f8da41c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Unified way of writing OIDs Fixed Scales Replaced wrong OIDs
Use the Name or Label of the Interface. Depending on the configuration this might not be unique, however it helps inunderstanding the produced data as there is otherwise no easy way of knowing which Index belongs to which Interface. E.g. the first Interfaces usually are used for the physical ports, but e.g. tplink has internal Interfaces like loopback first.
… displayed by cgp
out
errors of interfaces as well (example with no errors).
We might want to update the
/etc/collectd/conf.d/bbb-snmp.conf
file after this PR got merged for affected router to get correct data reported. This can be done without a sysupgrade by simply replacing this file and doing areload
ofcollectd
.