Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falter-berlin-autoupdate: Add custom-config detection #431

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Akira25
Copy link
Member

@Akira25 Akira25 commented May 23, 2024

Kompiliert Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an)
Läuft live Ja/Nein: (Bitte gib Prozessorarchitektur, Modell und Falter/OpenWrtversion an und wie du deine Änderungen getestet hast)

Beschreibung deiner Änderungen:


Compile tested: no
Run tested: yes, on falter 1.2.3

When updating nodes automatically, we want to detect custom changes made by the user. As nodes may brake when using non-standard config and updating, we want to avoid updating on these nodes.

Akira25 added 2 commits May 22, 2024 15:53
When updating nodes automatically, we want to detect custom changes made by
the user. As nodes may brake when using non-standard config and updating,
we want to avoid updating on these nodes.

Signed-off-by: Martin Hübner <martin.hubner@web.de>
Pretty unsure, how this was able to work on the last update. :/

Signed-off-by: Martin Hübner <martin.hubner@web.de>
@pmelange
Copy link
Collaborator

Is the uci-defaults script designed to always run when the router boots? Then it would be best to have an explicit "exit 1" at the end of the code. An "exit 0" causes the file to be deleted and anything else makes the uci-defaults script stay around for the next boot.

@Akira25
Copy link
Member Author

Akira25 commented May 28, 2024

Is the uci-defaults script designed to always run when the router boots? Then it would be best to have an explicit "exit 1" at the end of the code. An "exit 0" causes the file to be deleted and anything else makes the uci-defaults script stay around for the next boot.

Not quite: The script is intended, to only run once after the wizard finished. Thus we check, wether it ran already and exit , when it hasn't.

So we make checksums of a freshly configured router and check them on autoupdate against the current ones, to detect changes in the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants