Openwrt 19x: luci-master: add new dependency to luci-lib-ipkg #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmelange
changed the title
|
as the code is not changing, just the dependencies, only the revision should be bumped. |
SvenRoederer
pushed a commit
that referenced
this pull request
Mar 17, 2019
This became an issue because the luci-lib-ipkg code has been removed from luci-base. The upstream commit is openwrt/luci@4bbe325 This implemtents #158 Versionnumbering changed by Sven Roederer
SvenRoederer
added a commit
that referenced
this pull request
Mar 17, 2019
The package "luci-lib-ipkg" was split from "luci-base" in openwrt/luci@4bbe325. This is part of #158
pmelange
force-pushed
the
dependency-luci-lib-ipkg
branch
2 times, most recently
from
17c3a83 to
d872b4c
Compare
|
Done, but the branch is so out of date from the master branch that both makefiles cause a conflict. There are currently many PR's which are modifying the makefiles. As soon as one is committed, all the others instantly cause conflicts. Therefore, I would prefer to wait until we move to the 19.x branch, and all other commits are merged, before attempting to resolve this conflict. |
pmelange
added a commit
to freifunk-berlin/firmware
that referenced
this pull request
Jun 3, 2019
**Do not merge until the firmware is based on OpenWRT 19.x** **freifunk-berlin/firmware-packages#158 needs to be merged first** The comment from the upstream commit is: Add a new luci-app-opkg which is a feature-complete replacement for the builtin opkg functionality of luci-mod-system using mostly client side JavaScript to reduce the amount of server side processing. luci-app-opkg is not added to the 4MB devices. See #626 The upstream commit in openwrt/luci is openwrt/luci@aa2e0e2 The freifunk-berlin issue is #621
pmelange
changed the title
|
@SvenRoederer Can you please cherry-pick these changes into the daily/upstream-1907 branch? |
|
I don't see a daily/upstream-1907 branch here. |
|
OK, then whatever branch is being used to build the upstream-1907 images. Perhaps you haven't tested the upstream-1907 images, but luci produces errors that these changes fix |
|
The firmware-barnch "daily/upstream-1907" uses master-branch of this repo. I Don't like the idea of adding an other branch, that needs additional maintenance ... |
SvenRoederer
added a commit
that referenced
this pull request
Jul 6, 2019
The package "luci-lib-ipkg" was split from "luci-base" in openwrt/luci@4bbe325. This is part of #158
SvenRoederer
pushed a commit
that referenced
this pull request
Jul 9, 2019
This became an issue because the luci-lib-ipkg code has been removed from luci-base. The upstream commit is openwrt/luci@4bbe325 This implemtents #158 Versionnumbering changed by Sven Roederer
SvenRoederer
added a commit
to SvenRoederer/freifunk-berlin-firmware
that referenced
this pull request
Aug 8, 2019
SvenRoederer
added a commit
to freifunk-berlin/firmware
that referenced
this pull request
Aug 8, 2019
SvenRoederer
added a commit
to freifunk-berlin/firmware
that referenced
this pull request
Oct 14, 2019
This became an issue because the luci-lib-ipkg code has been removed from luci-base. The upstream commit is openwrt/luci@4bbe325
SvenRoederer
force-pushed
the
dependency-luci-lib-ipkg
branch
from
d872b4c to
1cd2cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before the firmware is based off of OpenWRT 19.x
This is specific for the luci-master branch
This became an issue because the luci-lib-ipkg code has been
removed from luci-base. The upstream commit is
openwrt/luci@4bbe325