reuse LUCI build-support #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build-directory looks like this after adding this: |
|
Is this for OpenWrt 18.x or 19.x or both? |
|
For all recent OpenWrt-versions, that would also work for 17.01 based Hedy. |
|
Is this change a way we'd like to go for or do we want to keep the manual versioning? |
SvenRoederer
force-pushed
the
use_luci.mk
branch
from
59c3d66 to
57a0753
Compare
SvenRoederer
force-pushed
the
use_luci.mk
branch
from
57a0753 to
036751d
Compare
The luci.mk file of the LUCI-feed provides some usefull macros and definitions to build (luci based) packages. These macros include SRCDIET, JSMIN, CSSTIDY and automatic build of translations. This script checks the root of every feed for the luci.k file and includes it.
this switches to git-hash versionnumbering
this is a direct copy from luci-feeds luci.mk
So a commit to a package will not change the versionnumber of all packages of the feed.
rely on freifunk-berlin-generic.mk as bridge
SvenRoederer
force-pushed
the
use_luci.mk
branch
from
036751d to
4da38cf
Compare
SvenRoederer
added a commit
that referenced
this pull request
Dec 25, 2019
|
merged with c212966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the use of "luci.mk" from the LUCI feed to reuse its macros and definitions. So the packages-makefiles can be kept a bit more simple and use features like SRCDIET and automatic build of translations.
Some of our packages will be changed to use versionnumbering based on the githash, which removes the need for taking care of this "detail".
This also fixes freifunk-berlin/firmware#584