bbbdigger: use uci-default script in place of separate shell script #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since some time the uci-default scripts are ran after installing a package with opkg. So we can use this method also to trigger the runtime config-setup and cleanup the Makefile even more.
|
According to https://openwrt.org/docs/guide-developer/packages, a post-install script is what should be used. After looking at the various packages in openwrt/packages, post-install scripts are used extensively. I have yet to find a package which makes use of uci-defaults exclusively. What I have seen, are packages which put the contents of the post-install script in a uci-default in case a package is burnt into an image. This package should not be burnt into the freifunk images. It is an add-on. I think that we should stay with postinst. Regardless, this PR needs to be changed to add an |
|
just updated the OpenWrt-wiki regarding the uci-defaults. The feature was added in openwrt/openwrt@9b9c78e |
everloop2
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some time the uci-default scripts are ran after installing a package with opkg. So we can use this method also to trigger the runtime config-setup and can drop doing it with the PostInstall-script.
This will make the code more "clean".