Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmuc-mesh-vpn-wireguard: use urandom instead awk #101

Merged

Conversation

grische
Copy link
Contributor

@grische grische commented Mar 26, 2024

awk's srand() uses only second-precision for its initial time-based seed. That leads to many routers getting the same random number.

Replacing with busybox' hexdump and /dev/urandom that provides much better random numbers.

Found in: #100 (comment)

@grische grische marked this pull request as ready for review March 26, 2024 13:10
@grische grische requested review from awlx and maurerle March 26, 2024 13:10
awk's srand() uses only second-precision for its initial time-based seed.
That leads to many routers getting the same random number.

Replacing with busybox' hexdump and /dev/urandom that provides much better
random numbers.
@grische grische force-pushed the fix/replace-srand-with-urandom branch from b68da0e to 60868d5 Compare March 26, 2024 15:22
@grische grische merged commit e54d2df into freifunk-gluon:master Mar 26, 2024
2 checks passed
@grische grische deleted the fix/replace-srand-with-urandom branch March 26, 2024 15:23
grische added a commit to grische/site-ffm that referenced this pull request Mar 27, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
github-actions bot pushed a commit to freifunkMUC/site-ffm that referenced this pull request Mar 27, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102

(cherry picked from commit fc42990)
grische added a commit to grische/site-ffm that referenced this pull request Apr 6, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
grische added a commit to grische/site-ffm that referenced this pull request Apr 6, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
grische added a commit to grische/site-ffm that referenced this pull request Apr 6, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
grische added a commit to grische/site-ffm that referenced this pull request Apr 6, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
grische added a commit to grische/site-ffm that referenced this pull request Apr 6, 2024
The new version of ffmuc-mesh-vpn-wireguard-vxlan supports load-balancing
of clients using wgkex.

For details, see
- freifunkMUC/wgkex#87
- freifunk-gluon/community-packages#100
- freifunk-gluon/community-packages#101
- freifunk-gluon/community-packages#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants