Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid or missing image-customization.lua is ignored #3218

Closed
neocturne opened this issue Mar 7, 2024 Discussed in #3217 · 0 comments · Fixed by #3219
Closed

Invalid or missing image-customization.lua is ignored #3218

neocturne opened this issue Mar 7, 2024 Discussed in #3217 · 0 comments · Fixed by #3219
Labels
0. type: bug This is a bug 3. topic: build This is about the build system 6. skill: lua This issue can be fixed with some Lua knowledge 7. v2023.2.x

Comments

@neocturne
Copy link
Member

The build should abort when no valid image-customization.lua is found, rather than continuing as if the file were empty.
@neocturne neocturne added 0. type: bug This is a bug 6. skill: lua This issue can be fixed with some Lua knowledge 3. topic: build This is about the build system 7. v2023.2.x labels Mar 7, 2024
neocturne added a commit to neocturne/gluon that referenced this issue Mar 7, 2024
@neocturne
scripts: image_customization_lib.lua: fail build without valid custom…
f13bdea 
…ization file

image-customization.lua has replaced GLUON_FEATURES and
GLUON_SITE_PACKAGES, so the file is always required to build a useful
Gluon image. In addition, not only 'file not found' errors were ignored,
but also all other Lua load errors, resulting in a build with empty
image customization when the file was not valid.

Closes freifunk-gluon#3218
@neocturne neocturne mentioned this issue Mar 7, 2024
Merged
neocturne added a commit to neocturne/gluon that referenced this issue Mar 7, 2024
@neocturne
scripts: image_customization_lib.lua: fail build without valid custom…
7feaec8 
…ization file

image-customization.lua has replaced GLUON_FEATURES and
GLUON_SITE_PACKAGES, so the file is always required to build a useful
Gluon image. In addition, not only 'file not found' errors were ignored,
but also all other Lua load errors, resulting in a build with empty
image customization when the file was not valid.

Closes freifunk-gluon#3218
github-actions bot pushed a commit that referenced this issue Mar 8, 2024
@neocturne @github-actions
scripts: image_customization_lib.lua: fail build without valid custom…
2fd7080 
…ization file

image-customization.lua has replaced GLUON_FEATURES and
GLUON_SITE_PACKAGES, so the file is always required to build a useful
Gluon image. In addition, not only 'file not found' errors were ignored,
but also all other Lua load errors, resulting in a build with empty
image customization when the file was not valid.

Closes #3218

(cherry picked from commit 7feaec8)
blocktrron pushed a commit that referenced this issue Mar 8, 2024
@github-actions @neocturne
scripts: image_customization_lib.lua: fail build without valid custom…
d4d9db7 
…ization file (#3220)

image-customization.lua has replaced GLUON_FEATURES and
GLUON_SITE_PACKAGES, so the file is always required to build a useful
Gluon image. In addition, not only 'file not found' errors were ignored,
but also all other Lua load errors, resulting in a build with empty
image customization when the file was not valid.

Closes #3218

(cherry picked from commit 7feaec8)

Co-authored-by: Matthias Schiffer <mschiffer@universe-factory.net>
hafu pushed a commit to Freifunk-Potsdam/gluon that referenced this issue Jun 2, 2024
@github-actions @neocturne @hafu
scripts: image_customization_lib.lua: fail build without valid custom…
dd98784 
…ization file (freifunk-gluon#3220)

image-customization.lua has replaced GLUON_FEATURES and
GLUON_SITE_PACKAGES, so the file is always required to build a useful
Gluon image. In addition, not only 'file not found' errors were ignored,
but also all other Lua load errors, resulting in a build with empty
image customization when the file was not valid.

Closes freifunk-gluon#3218

(cherry picked from commit 7feaec8)

Co-authored-by: Matthias Schiffer <mschiffer@universe-factory.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. type: bug This is a bug 3. topic: build This is about the build system 6. skill: lua This issue can be fixed with some Lua knowledge 7. v2023.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scripts: image_customization_lib.lua: fail build without valid customization file neocturne/gluon
1 participant
@neocturne