Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-web-cellular: add auth option to GUI #3307

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

T0biii
Copy link
Contributor

@T0biii T0biii commented Jul 6, 2024

this should fixes #2750 by adding a dropdown menu for the auth methods.

atm it is untested, but we believe that this can be tested soon by someone from ffmuc.

More Infos:
https://openwrt.org/docs/guide-user/network/wan/wwan/ltedongle#qmi_protocol_configuration_parameters

@github-actions github-actions bot added 3. topic: package Topic: Gluon Packages 3. topic: config-mode This is about the configuration mode labels Jul 6, 2024
Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@blocktrron blocktrron marked this pull request as ready for review July 10, 2024 11:25
Copy link
Member

@blocktrron blocktrron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI

@AiyionPrime
Copy link
Member

atm it is untested

Could we wait for the test report prior merging?

@seilpforte
Copy link

I just tested this, works fine.

root@ff-router:~# uci show | grep cellular
firewall.@zone[1].network='wan' 'wan6' 'cellular_4' 'cellular_6'
gluon.cellular=cellular
gluon.cellular.enabled='1'
gluon.cellular.apn='internet.eplus.de'
gluon.cellular.username='eplus'
gluon.cellular.pdptype='IPV4V6'
gluon.cellular.pin='1234'
gluon.cellular.password='internet'
gluon.cellular.auth='chap'
network.cellular=interface
network.cellular.proto='qmi'
network.cellular.disabled='0'
network.cellular.device='/dev/cdc-wdm0'
network.cellular.peerdns='0'
network.cellular.apn='internet.eplus.de'
network.cellular.pdptype='IPV4V6'
network.cellular.ipv6='auto'
network.cellular.pincode='1234'
network.cellular.username='eplus'
network.cellular.password='internet'
network.cellular.auth='chap'
network.cellular.delay='15'

cellularPNG

Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würd' die Übersetzungen noch vervollständigen, aber sonst sieht's klasse aus.
Wenn ihr den so mergen wollt, können wir für die Übersetzung auch gerne einen neuen PR eröffnen.

package/gluon-web-cellular/i18n/de.po Outdated Show resolved Hide resolved
package/gluon-web-cellular/i18n/de.po Outdated Show resolved Hide resolved
package/gluon-web-cellular/i18n/de.po Outdated Show resolved Hide resolved
@T0biii
Copy link
Contributor Author

T0biii commented Jul 10, 2024

habe die vorgeschlagenen Änderungen direkt noch hinzugefügt :)

@blocktrron blocktrron merged commit 5a85485 into freifunk-gluon:main Jul 11, 2024
9 checks passed
@T0biii T0biii deleted the web-cellular branch July 12, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: config-mode This is about the configuration mode 3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cellular: authentication dropdown missing
5 participants