Skip to content

Commit

Permalink
new dns system for neonetwork
Browse files Browse the repository at this point in the history 
Signed-off-by: Jerry <isjerryxiao@outlook.com>
  • Loading branch information
@isjerryxiao @mweinelt
isjerryxiao authored and mweinelt committed Sep 24, 2020
1 parent a341ad6 commit 763c74e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion neonetwork
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
domains:
- neo
- 127.10.in-addr.arpa
- 7.2.1.0.0.1.d.f.ip6.arpa
nameservers:
- 10.127.255.2
- 10.127.255.53
- fd10:127:ffff:53::
networks:
ipv4:
- 10.127.0.0/16 # in use
Expand Down

3 comments on commit 763c74e

@mart-ffbsee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notation of the IPv6 nameserver while completely valid still causes icvpn-scripts/mkdns -f unbound to produce an erronous unbound conf file.
fd10:127:ffff:53::0 instead would solve this, but I guess it's really a problem of the icvpn-scripts/mkdns script. Just referencing this here.

@fblaese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change completely breaks icvpn-scripts/mkdns -f bind, because fd10:127:ffff:53:: is interpreted as a a dict instead of a string, because it ends with a colon.
Either the address has to be quoted or a trailing '0' has to be added, as previously suggested.

@mweinelt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ae6bf8a

Please sign in to comment.