Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freifunk-policyrouting: do not run init-script in imagebuilder #10

Closed
SvenRoederer opened this issue May 2, 2019 · 2 comments
Closed

freifunk-policyrouting: do not run init-script in imagebuilder #10

SvenRoederer opened this issue May 2, 2019 · 2 comments

Comments

@SvenRoederer
Copy link
Contributor

This is to follow up openwrt/luci#1635 after splitting freifunk-packages from luci-feed. Original issue-statment below:

When creating final images the build-scripts running the package init-scripts. As of including files like on a real system (line 4, 5), with absolute path, this will fail.

Activating init scripts
build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 4: /lib/functions/network.sh: No such file or directory
build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 5: /lib/functions.sh: No such file or directory

Running this init-script outside of a real-system don't seem to make sense at all, so just exit gracefully.
@SvenRoederer
Copy link
Contributor Author

As per openwrt/luci#1635 (comment), openwrt/luci#1635 (comment) the init-scripts are now enabled by default in OpenWrt. As this was probably not done in the very early OpenWrt releases, out postinst was added to the package. When OpenWrt changed to activate the init-scripts by default, this was very likely the moment when this error came up.

there is also an Issue in the Freifunk-Berlin project relating to this: freifunk-berlin/firmware#423 (comment)

SvenRoederer added a commit that referenced this issue Jan 2, 2020
@SvenRoederer
policyrouting: honor $IPKG_INSTROOT in init-script
2d53e66 
Prefix the inclusion of the OpenWrt-files with $IPKG_INSTROOT, to avoid
"No such file or directory" errors.
This takes care of #10 in the same
way as it's done in other packages. (e.g. strongswan)

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
@SvenRoederer SvenRoederer mentioned this issue Jan 2, 2020
Closed
SvenRoederer added a commit that referenced this issue Feb 16, 2020
@SvenRoederer
policyrouting: honor $IPKG_INSTROOT in init-script
69eb221 
Prefix the inclusion of the OpenWrt-files with $IPKG_INSTROOT, to avoid
"No such file or directory" errors.
This takes care of #10 in the same
way as it's done in other packages. (e.g. strongswan)

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
SvenRoederer added a commit that referenced this issue Feb 16, 2020
@SvenRoederer
policyrouting: honor $IPKG_INSTROOT in init-script
81661b7 
Prefix the inclusion of the OpenWrt-files with $IPKG_INSTROOT, to avoid
"No such file or directory" errors.
This takes care of #10 in the same
way as it's done in other packages. (e.g. strongswan)

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
@SvenRoederer SvenRoederer mentioned this issue Feb 16, 2020
Open
@SvenRoederer
Copy link
Contributor Author

fixed by 5425bc9

@SvenRoederer SvenRoederer mentioned this issue Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SvenRoederer