Added: GitHub Action to check for typos in our code #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
reviewed
Mar 10, 2022
Comment on lines
+4
to
+12
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: | ||
| - master | ||
| schedule: | ||
| - cron: '45 9 * * 1' |
There was a problem hiding this comment.
Why does this run on a schedule? What happens if it finds a spelling mistake during a scheduled run, how will it notify us?
I don't think it should run on pushes to master either. This will only cause annoying CI failures on master that nobody will fix anyway. This should just run on PRs where the PR author will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by #122
Closes #124