Redirect to signin page after failed OIDC login #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
added
bug
|
Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you want to sign-in to wg-access-server using an OIDC provider, but then abort the process (or it otherwise fails), you end up with a nil
AuthSession.Identity.This makes the
ClaimsMiddlewarefail, and users see an Internal Server Error. The logs sayauthz middleware failure: User is not logged insince #194, before they were missing completely.Changes
Now the
AuthMiddlewareexplicitly checks for the identity not being nil. If it is, it redirects to/signin, the user logging in successfully this time is our best bet at resolving whatever is wrong.While this is the only possible error case of
ClaimsMiddlewareright now and can no longer be triggered with the above change, for future-proofing we also redirect to/signinwhenClaimsMiddlewareencounters errors.Closes #179 again
Closes #201 probably