Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Gitleaks Action repository as the LICENSE has changed #225

Merged
merged 6 commits into from
Jul 31, 2022

Conversation

GoliathLabs
Copy link
Member

@GoliathLabs GoliathLabs commented Jul 23, 2022

With version v2.0.0 the license of the gitleaks-action has changed. A fork has been created which still uses the old license

Before enabling Gitleaks-Action Version 2, you will need to obtain a gitleaks-action license key from [gitleaks.io](https://gitleaks.io/products) if you are using gitleaks within the context of an organization. If you are using gitleaks-aciton on a user account's repo, you do not need a license key. You can sign up for a free license key that will grant you access to use gitleaks-action on one repo. The free tier sign up link will take you to a google forms page where you can fill out your information. After filling out your information, you should receive an email similar to the one below.

Source: https://github.com/gitleaks/gitleaks-action/releases/tag/v2.0.0

@mergeable
Copy link

mergeable bot commented Jul 23, 2022

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@GoliathLabs GoliathLabs requested a review from a team July 23, 2022 23:13
@DasSkelett
Copy link
Member

DasSkelett commented Jul 28, 2022

So the new Gitleaks did find some "leaks".

  • The first two aren't really leaks, the k8s quickstart.yml just included random placeholders that were generated during rendering of the Helm templates.
    04a37c7
  • The third one was indeed a leak, some contributor pushed their local config.yaml in a PR before our fork. and removed it again in a follow-up commit (and unfortunately they were not squashed before merge, now we have this ugly add-then-remove in the history 🙄)

Do you know how to tell Gitleaks that we don't care about these three?

@GoliathLabs
Copy link
Member Author

GoliathLabs commented Jul 28, 2022

@DasSkelett seems that there is a proper configuration for gitleaks where you can ignore certain commits https://github.com/zricethezav/gitleaks#configuration

I don't know if I can finish this today since I will be away from my computer later, but I will to get it done by tomorrow evening

@GoliathLabs GoliathLabs merged commit 945d5b7 into master Jul 31, 2022
@GoliathLabs GoliathLabs deleted the GoliathLabs-patch-2 branch July 31, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants