Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require claim to be present to allow access to the user #259

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

nextsux
Copy link

@nextsux nextsux commented Oct 9, 2022

This PR should allow admin to require OIDC claim to be present for user to be able to access wg-access-server.

Closes #200

@mergeable
Copy link

mergeable bot commented Oct 9, 2022

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@nextsux nextsux changed the title feat: require claim to be present to allow access to the user WIP: require claim to be present to allow access to the user Oct 9, 2022
@nextsux nextsux marked this pull request as draft October 9, 2022 12:47
@nextsux nextsux force-pushed the require-claim-to-allow-access branch from cd37103 to 3be021b Compare October 9, 2022 20:34
@nextsux nextsux changed the title WIP: require claim to be present to allow access to the user Require claim to be present to allow access to the user Oct 9, 2022
@nextsux nextsux marked this pull request as ready for review October 9, 2022 20:34
@GoliathLabs
Copy link
Member

@nextsux has this been properly tested?

@nextsux
Copy link
Author

nextsux commented Oct 24, 2022

I have it in production and it works nicely @GoliathLabs

cmd/serve/main.go Outdated Show resolved Hide resolved
Co-authored-by: DasSkelett <dasskelett@gmail.com>
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the contribution and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a 'user' claim similar to the 'admin claim for OIDC
3 participants