Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the auth methods 'name' field to the login buttons, if it differs from the auth type. #382

Conversation

nwaldispuehl
Copy link

This is supposed to improve the usability for non-IT corporate users:
We had a hard time* to convince our technically less inclined users that 'OIDC' in fact means our companys Keycloak SSO server. I always wished I could arbitrarily name the login buttons; hence this feature.

What do you think?

(* actually not really hard, but for the sake of the argument... 😬 )


Given this config file extract:

...
auth:
  ...
  oidc:
    # A name for the backend (is shown on the login page and possibly in the devices list of the 'all devices' admin page)
    name: "MyCompany SSO"
    ...

  gitlab:
    name: "MyCompany Gitlab"
    ...

the login screen previously looked like this:
2023-05-15_20-46

and with this change would look like this:
2023-05-15_20-49

To implicitly reproduce the old behavior one would need to set the name to the type:

  gitlab:
    name: "gitlab"

…s from the auth type.

This is supposed to improve the usability for non-IT corporate users.
@nwaldispuehl nwaldispuehl added the enhancement New feature or request label May 15, 2023
@nwaldispuehl nwaldispuehl requested a review from a team as a code owner May 15, 2023 19:09
@nwaldispuehl nwaldispuehl self-assigned this May 15, 2023
@mergeable
Copy link

mergeable bot commented May 15, 2023

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

Copy link
Member

@GoliathLabs GoliathLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwaldispuehl nwaldispuehl merged commit 0ebcdfd into freifunkMUC:master May 18, 2023
@nwaldispuehl nwaldispuehl deleted the feature/add-customizable-name-to-auth-method branch May 18, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants