Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pymdown-extenstions to non-vuln version #383

Merged
merged 2 commits into from
May 18, 2023

Conversation

GoliathLabs
Copy link
Member

Summary

This PR updates the pymdown-extensions to a non-vulnerable version.
Arbitrary file read when using include file syntax.

Details

By using the syntax --8<--"/etc/passwd" or --8<--"/proc/self/environ" the content of these files will be rendered in the generated documentation. Additionally, a path relative to a specified, allowed base path can also be used to render the content of a file outside the specified base paths: --8<-- "../../../../etc/passwd".

Within the Snippets extension, there exists a base_path option but the implementation is vulnerable to Directory Traversal.
The vulnerable section exists in get_snippet_path(self, path) lines 155 to 174 in snippets.py.

base = "docs"
path = "/etc/passwd"
filename = os.path.join(base,path) # Filename is now /etc/passwd

PoC

import markdown

payload = "--8<-- \"/etc/passwd\""
html = markdown.markdown(payload, extensions=['pymdownx.snippets'])

print(html)

Impact

Any readable file on the host where the plugin is executing may have its content exposed. This can impact any use of Snippets that exposes the use of Snippets to external users.

It is never recommended to use Snippets to process user-facing, dynamic content. It is designed to process known content on the backend under the control of the host, but if someone were to accidentally enable it for user-facing content, undesired information could be exposed.

@GoliathLabs GoliathLabs requested a review from a team as a code owner May 17, 2023 00:25
@mergeable
Copy link

mergeable bot commented May 17, 2023

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

requirements-docs.txt Outdated Show resolved Hide resolved
@GoliathLabs GoliathLabs merged commit 6391869 into master May 18, 2023
@GoliathLabs GoliathLabs deleted the GoliathLabs-patch-1 branch May 18, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants