Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config to set the MTU on a interface #429

Merged
merged 1 commit into from
Jul 20, 2023
Merged

add config to set the MTU on a interface #429

merged 1 commit into from
Jul 20, 2023

Conversation

fbuetler
Copy link

See #417

@fbuetler fbuetler requested a review from a team as a code owner July 19, 2023 08:34
@fbuetler fbuetler added this to the 0.10.0 milestone Jul 19, 2023
@fbuetler fbuetler linked an issue Jul 19, 2023 that may be closed by this pull request
Create MTU config setting for server #417
Closed
@mergeable
Copy link

mergeable bot commented Jul 19, 2023

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@fbuetler fbuetler added the enhancement New feature or request label Jul 19, 2023
@nwaldispuehl
Copy link

Cool, thank you!

nwaldispuehl
nwaldispuehl requested changes Jul 19, 2023
View reviewed changes
Copy link

@nwaldispuehl nwaldispuehl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the new flag to the commandline arguments, documentation, and possibly the serverinfo which is sent to the frontend.

Edit: You are sooo fast 🚀 ✨ 😊 ! CLI args und documentation is already done!

nwaldispuehl
nwaldispuehl reviewed Jul 19, 2023
View reviewed changes
cmd/serve/main.go Outdated Show resolved Hide resolved
@fbuetler fbuetler force-pushed the feature/add-mtu-config branch 2 times, most recently from fc2cce5 to 03a4edd Compare July 19, 2023 09:00
nwaldispuehl
nwaldispuehl reviewed Jul 19, 2023
View reviewed changes
cmd/serve/main.go Outdated Show resolved Hide resolved
nwaldispuehl
nwaldispuehl reviewed Jul 19, 2023
View reviewed changes
proto/server.proto Outdated Show resolved Hide resolved
@GoliathLabs
Copy link
Member

@fbuetler @nwaldispuehl thank you so much for your hard work! I really appreciate it ❤️

@fbuetler fbuetler merged commit e1a0588 into master Jul 20, 2023
@fbuetler fbuetler deleted the feature/add-mtu-config branch July 20, 2023 11:26
@nwaldispuehl nwaldispuehl mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwaldispuehl nwaldispuehl nwaldispuehl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Create MTU config setting for server
3 participants
@fbuetler @nwaldispuehl @GoliathLabs