-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add darkmode after login #581
Conversation
Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. |
A toggle option would be nice. What exactly didn't work out for you? |
the |
here are the branche where i tested more stuff: |
@T0biii you could try an useEffect call for that.
Not the cleanest solution, though. Perhaps @nwaldispuehl has an idea? |
i dont know where |
I will happily have a look at it in the next days. |
- initializing the theme with the OS setting - adding toggle button in navigation bar - introducing global state - keeping user preference in local storage (if different to OS setting)
First thanks for the cool feature, @T0biii ! 👍 I allowed myself to just add the missing things:
|
looks very good too me. thank you for taking it on. |
i only found if you want to delete a device/user from the Admin Page it is not in darkmode |
Merged. Thank you @T0biii @nwaldispuehl <3 |
big thanks to @nwaldispuehl for making the important chagnes |
added darkmode but atm only darkmode, no light mode:
i tried this form the Docs:
https://mui.com/material-ui/customization/dark-mode/#system-preference
but it did not work for me
maybe add also a toggle like:
https://mui.com/material-ui/customization/dark-mode/#toggling-color-mode
"/"
"/admin/all-devices"
"Popup"