Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new Loading Style and add Error Message #594

Merged
merged 11 commits into from
Mar 3, 2024
Merged

add new Loading Style and add Error Message #594

merged 11 commits into from
Mar 3, 2024

Conversation

T0biii
Copy link
Member

@T0biii T0biii commented Feb 29, 2024 •
edited
Loading

add new Loading Style:
image

and add Error Message:
image
image

@mergeable Mergeable
Copy link

mergeable bot commented Feb 29, 2024

Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

@nwaldispuehl nwaldispuehl self-assigned this Feb 29, 2024
@nwaldispuehl
Copy link

Will have a look at it over the weekend.

@T0biii
Copy link
Member Author

T0biii commented Feb 29, 2024 •
edited
Loading

no worries this has no priority it was just an idea because I didn't like <p>Loading....</p> that much

@nwaldispuehl
Copy link

nwaldispuehl commented Mar 3, 2024 •
edited
Loading

First, thank you for the PR, very nice addition!
It might sound cheesy, but again I idly wondered many times before if we could replace this dull Loading... screen which showed when the backend is not yet up. Cool that we now have a more beautiful entrypoint.
We could merge it as is, but I rather would like some issues improved before:

nwaldispuehl
nwaldispuehl reviewed Mar 3, 2024
View reviewed changes
website/src/components/Loading.tsx Outdated Show resolved Hide resolved
website/src/components/Error.tsx Outdated Show resolved Hide resolved
website/src/components/Devices.tsx Show resolved Hide resolved
website/src/components/Loading.tsx Show resolved Hide resolved
@T0biii T0biii marked this pull request as ready for review March 3, 2024 15:04
@T0biii T0biii requested a review from a team as a code owner March 3, 2024 15:04
nwaldispuehl
nwaldispuehl reviewed Mar 3, 2024
View reviewed changes
website/src/App.tsx Outdated Show resolved Hide resolved
@nwaldispuehl
Copy link

Very nice! 👍

@nwaldispuehl nwaldispuehl merged commit d88e33a into freifunkMUC:master Mar 3, 2024
10 checks passed
@T0biii T0biii mentioned this pull request Mar 3, 2024
Merged
GoliathLabs pushed a commit that referenced this pull request Mar 3, 2024
@T0biii
follow-up #594 (Error Box Styling, remove redudant code in App.tsx) (#…
93b8c70 
…605)

* change styling like the Loading styling

* Remove redundant Code (ChatGPT)

* extract content in new function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwaldispuehl nwaldispuehl nwaldispuehl approved these changes

Assignees

@nwaldispuehl nwaldispuehl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T0biii @nwaldispuehl