Update dependencies: Wireguard, go-ini and logrus #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* github.com/sirupsen/logrus v1.6.0 -> v1.8.1 * golang.zx2c4.com/wireguard v0.0.20200320 -> v0.0.0-20211129173154-2dd424e2d808 * golang.zx2c4.com/wireguard/wgctrl v0.0.0-20200609130330-bd2cb7843e1b -> v0.0.0-20211207222515-92d582e4e166 * gopkg.in/ini.v1 v1.57.0 -> v1.66.2 I had to upgrade golang.zx2c4.com/wireguard and golang.zx2c4.com/wireguard/wgctrl to the latest master commit, as peers couldn't connect with the latest tag. The Wireguard upgrade required changes to iface.go, because `device.NewDevice()` now takes a `conn.Bind` parameter, we just create a `NewDefaultBind()` for that. The ini upgrade deprecated `ini.DEFAULT_SECTION`, it is now called `ini.DefaultSection`, `parse()` in config.go has been adjusted accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's upgrade dependencies again!
The Wireguard dependency was tripping up Dependabot on wg-access-server because the old tags no longer exist:
Changes
The latest tagged version of Wireguard was buggy, peers couldn't connect because they never reached the
runningstate, and handshake packets errored withReceived invalid initiation message. So I chose the latest commit onmasterinstead, which works just fine.The Wireguard upgrade required changes to iface.go, because
device.NewDevice()now takes aconn.Bindparameter, we just callconn.NewDefaultBind()for that, like wireguard-go does, too.It will also bump the minimum Go version required for compilation to Go 1.17, as Wireguard uses some new language features.
The ini upgrade deprecated
ini.DEFAULT_SECTION, it is now calledini.DefaultSection,parse()in config.go has been adjusted accordingly.Also thanks to go-ini/ini#220 go-ini supports duplicate section names (i.e. multiple
Peersections), which simplifies config parsing a lot.Technically this was already present in v1.57.0, but place1 never updated the code despite the comment.
I've expanded one of the unit test cases to make sure the parsing works as expected (although wg-access-server never uses any ini files)