action to check patches #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiyionPrime
commented
Apr 25, 2023
| @@ -55,6 +49,3 @@ index 00000000..7d92a1c2 | |||
| ++-- | |||
There was a problem hiding this comment.
This looks odd, and should have been gone.
But maybe this is yet another level, I just have not cleaned up.
|
Cron trigger is in place for both actions. |
to match gluon style
a helper script, that refreshes the outer layer of site patches. Caliing it on a clean patchfolder does not invoke changes; hence, if calling it results in git changes, it is not clean.
|
Refreshed the patches, squashed intermediate commits and completed the list from above. |
Merged
1977er
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently implements only the gluon part.
The outer parts of the site patches are not checked, but have been brought in the same format as the inner patches.
Whats left todo:
efresh-site-patches.shdoes not change anything, hence the patches are indeed in a clean statemake refresh-patchesin gluon (should have been done already and makes upstreaming patches easier)refresh-site-patches.shin this repo afterwords (should be done to make maintaining patches easier and clearer)Merging this will eventually resolve #83 and make submitting patches a little harder, but cleaner, so that reviewing patch PRs to this repo will become easier.
Furthermore it won't matter anymore, which OS we used to format the patch.